Repository navigation
fix(binding): do not fail when the page was closed before the binding result arrived - #2022
Open
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Open
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Conversation
… result arrived Like the Node.js client, the result of a binding call is sent without waiting for the driver's answer, so a page that closed in the meantime does not fail the event dispatch. Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendMessage, which threw when the page had closed in the meantime and failed the enclosing call; send it asynchronously like the Node.js client.TestBrowserContextExposeFunction.https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM