Repository navigation
fix(screenshot): derive the screenshot type from the path extension like the Node.js client - #2021
Merged
Yury Semikhatsky (yury-s) merged 3 commits intoOct 26, 2026
Conversation
… Node.js client A screenshot path with an extension other than png, jpg, jpeg or webp was silently written as a PNG; the Node.js client throws 'path: unsupported mime type'. The path now also overrides the type option, as in the Node.js client. The porting guide notes that headed tests run under xvfb-run. Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
…on is given Like the Node.js client, an explicit type option wins over the extension of the path. SS-032 passes now, its @fixme is gone. Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
Pavel Feldman (pavelfeldman)
approved these changes
Oct 26, 2026
Yury Semikhatsky (yury-s)
merged commit Oct 26, 2026
1e592bb
into
microsoft:main
35 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathoption silently produced a PNG; it now throwspath: unsupported mime type "..."like the Node.js client.typeoption is given.TestPageScreenshot.https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM