Repository navigation
fix(context): attach HAR content for a .zip path and tolerate a disposed request context on close - #2020
Merged
Conversation
…sed request context on close
Path.endsWith(".zip") compares path elements and never matched; closing a
context whose request context the user had disposed threw TargetClosedError.
Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
…ng after request dispose Claude-Session: https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM
Pavel Feldman (pavelfeldman)
approved these changes
Oct 26, 2026
Yury Semikhatsky (yury-s)
merged commit Oct 26, 2026
4a6900e
into
microsoft:main
33 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.endsWith(".zip")compares the last path element, so arecordHarPathending in.zipembedded the content instead of attaching it; compare the file name string.context.close()threw whencontext.request().dispose()had been called before.TestBrowserContextHarandTestBrowserContextFetch.https://claude.ai/code/session_018p7xPf3r5VjAM7V46nzFTM