Repository navigation
test: skip export2python backend tests with optional_type inputs - #3078
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
With onnx-weekly, ORT now loads and runs the optional_has_element and optional_get_element_optional_tensor node tests, so the test reaches the export2python call, which sits outside the NotImplementedError guard. onnx_type_to_onnxscript_repr has no translation for optional_type, so four tests fail on the onnx-weekly and torch-nightly jobs instead of skipping. Skip those four explicitly, like the existing test_optional_get_element_tensor entry.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onnx-weekly and torch-nightly jobs on main fail four backend export tests (run 37558713688). With the new onnx, these node tests now load in onnxruntime, so the test reaches
export2python, which sits outside theNotImplementedErrorguard._translate_typehas no mapping foroptional_typeinputs:Same for 1207, 1211 and 1212. This adds two
SKIP_TESTSentries for those four tests, next to the existingtest_optional_get_element_tensorskip. Theempty_no_inputvariants still run.Locally with onnx 1.23.0.dev20260831 (the weekly pin), running the non-win32 skip list: before, 4 errors; after, all 11
test_optional*tests give OK (skipped=7), with 1213, 1214, 1216 and 1217 passing.ruff checkandruff format --checkare clean.