Repository navigation
Keep integer precision in rounded division - #3077
Open
Rio Yu (rioyu123) wants to merge 1 commit into
Open
Rio Yu (rioyu123) wants to merge 1 commit into
Rio Yu (rioyu123) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integer
torch.div(..., rounding_mode="floor")androunding_mode="trunc"currently pass through float32 during export. Large integer quotients can consequently change value: for example,50331653 / 3with either rounding mode produces16777218instead of16777217in ONNX Runtime.This change keeps rounded integer division in integers.
truncuses integerDiv, andfloorreuses the existingaten_floor_divideimplementation, including its correction for negative operands. Floating-point inputs and therounding_mode=Nonepath are unchanged.Fixes #3062.
Testing
e2e_ops_tests.py: 135 passed, 1 skipped, 5 failed. Unmodified main has the same five failures (STFTvalue_info, boolean SDPA, and dynamic unbind), with 127 passed and 1 skipped.lintrunner -aandgit diff --checkpassed.Tested on Windows with Python 3.12, PyTorch 2.14.1 CPU and ONNX Runtime 1.31.0. TensorRT and model-quality benchmarks were not run.