Repository navigation
Keep the saturate attribute when constant folding rewrites CastLike to Cast - #3075
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CastLikepartial evaluator rewritesCastLiketoCastwithout itssaturateattribute, sosaturate=0silently becomes the default 1. For a float8 target, values out of range then clamp to ±448 instead of becoming NaN. ONNX Runtime onCastLike <saturate = 0>tofloat8e4m3fnwith input[1000, 1, -1, 0.3]:The rewrite now forwards
saturate, which is what ONNX'sCastLikefunction body passes on toCast, including an@satreference inside a function.round_modeis not forwarded, matching that body; one test checks it stays off theCast.Three of the four new tests fail before the change.
onnxscript/optimizer: 78 passed, and the optimized models give the same ONNX Runtime output as the originals forsaturate=0,round_mode="down"and the@satfunction.ruff checkandruff format --checkare clean.