Repository navigation
Fix IndexError in fuse_pad_into_conv when Pad carries pads as an attribute - #3074
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_FuseConvPadBase.checkreadspad_node.inputs[1], but Pad before opset 11 carries the pads as an attribute and has one input, so the rule raisesIndexError. The rule is in the default set, sooptimizer.optimize()fails with aPassErroron a checker-valid opset-10 model where aPadfeeds aConv. The rule now declines that case and leaves the model unchanged.test_unsupported_fuse_pad_into_conv_with_pads_attributefails before with theIndexErrorand passes after._fuse_pad_into_conv_test.py: 40 passed.ruff checkandruff format --checkare clean.