Repository navigation
Fix xlogy returning 0 instead of NaN when self is 0 and other is NaN - #3073
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aten_special_xlogyapplied the NaN mask before the zero mask, soxlogy(0, nan)returned 0.torch.xlogyreturns NaN whereverotheris NaN, including whereselfis 0. Swapping the twoWherenodes makes the NaN case win. The masks only overlap whereselfis 0 andotheris NaN, so no other input changes.The new
e2e_ops_tests.pycase exportstorch.xlogyand compares with eager. It fails before (1 of 5 elements mismatched) and passes after.ruff checkandruff format --checkare clean.