Repository navigation
[Chore] Enhance PR process with issue discussion requirements - #5532
Merged
Denis Voituron (dvoituron) merged 1 commit intoOct 23, 2026
Merged
Conversation
…and a validation workflow
Denis Voituron (dvoituron)
requested a review
from Vincent Baaij (vnbaaij)
as a code owner
October 23, 2026 13:07
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation, template, and declaration workflow align, with no identified blocking correctness or security issues.
No open issues 🎉
What changed in this PR
This PR adds an issue-discussion requirement to the contribution process and a workflow that checks contributors have acknowledged it.
Changes:
- Document when maintainer agreement is required before implementation and which exceptions apply.
- Add an issue-discussion checkbox and issue-link guidance to the pull request template.
- Validate the declaration on pull request updates, exempting global code owners while leaving substantive policy checks to maintainers.
| File | Description |
|---|---|
docs/contributing.md |
Defines the discussion process, exceptions, and validation limits. |
.github/workflows/issue-discussion-declaration.yml |
Checks the declaration using trusted target-branch ownership data. |
.github/pull_request_template.md |
Adds the required checkbox and guidance for agreement links or exceptions. |
Review effort: Balanced
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.9%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Denis Voituron (dvoituron)
enabled auto-merge (squash)
October 23, 2026 13:26
Vincent Baaij (vnbaaij)
approved these changes
Oct 23, 2026
Denis Voituron (dvoituron)
deleted the
users/dvoituron/add-pr-issue-required
branch
October 23, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Chore] Enhance PR process with issue discussion requirements
Introduce a requirement for discussing changes in an issue before implementation, along with a validation workflow to ensure compliance. This change aims to streamline the pull request process and ensure alignment with project goals.
See the
contributing.mdfile with this new chapter:Before implementing a feature, a behavior change, or a non-trivial bug fix:
Fixes #1234when the pull request resolves the issue.This discussion helps avoid spending time on changes that do not fit the project's goals or design. Agreement to start implementation does not guarantee that the pull request will be accepted; normal review and testing requirements still apply.
Prior discussion is not required for small documentation-only corrections (such as spelling, grammar, or broken links), trivial bug fixes with an obvious solution and no API or intended behavior change, or automated dependency update pull requests. Explain the applicable exception in the pull request's Issues section. If you are unsure whether an exception applies, discuss the change in an issue first. Automated updates still require human review under the AI contribution policy.
Complete the checkbox in the pull request template's Issue discussion declaration section. The Issue discussion declaration workflow check fails if the declaration is missing or unchecked and runs again when the pull request description or commits change.
This check verifies the declaration only; it does not verify issue links, maintainer agreement, participation, or whether an exception applies. Maintainers validate these during review.