Repository navigation
fix(splitter): meet minimum contrast for resize bars - #5531
Open
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
Open
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
与世无争剑宇子 (yushiwuzhengjianyuzi) wants to merge 1 commit into
Conversation
与世无争剑宇子 (yushiwuzhengjianyuzi)
requested review from
Denis Voituron (dvoituron) and
Vincent Baaij (vnbaaij)
as code owners
October 23, 2026 12:04
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human author review remains pending, and rendered contrast has not been independently verified in both light and dark themes.
No open issues 🎉
What changed in this PR
Updates FluentMultiSplitter resize-bar styling to address the 3:1 non-text contrast requirement in #5505.
Changes:
- Uses accessible neutral stroke tokens for default, hover, and active bar states, with full opacity.
- Uses the neutral background token for resize-handle icons.
- Synchronizes the documented CSS custom-property defaults.
| File | Description |
|---|---|
| src/Core/Components/Splitter/FluentMultiSplitter.razor.css | Updates resize-bar colors, opacity, and icon colors. |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Splitter/MultiSplitter.md | Documents the updated defaults and new hover-color property. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5505
Summary
The resize bars use
--colorNeutralStroke2with an opacity of0.4, which makes them too faint against the surrounding surface and fails the 3:1 non-text contrast target.This change:
0.4opacity and changes the hover opacity to1.--colorNeutralBackground1for the resize-handle icon so it remains legible against the darker bar.Reviewer notes
This is a visual/accessibility-only change. The updated colors rely on the existing Fluent design tokens and should adapt to both light and dark themes.
Test plan
dotnet build src/Core/Microsoft.FluentUI.AspNetCore.Components.csproj— passed with 0 warnings and 0 errors.dotnet test tests/Core/Components.Tests.csproj --filter "FullyQualifiedName~Splitter"— 28 passed, 0 failed.git diff --check— passed.Checklist
AI contribution declaration
AI assistance is allowed; fully AI-generated or autonomous pull requests without meaningful human review are not accepted. See the AI contribution policy.
Component-specific
AI assistance: Codex was used to investigate the issue, implement the CSS/documentation changes, and run the listed validation. The author-review checkbox is intentionally left unchecked pending the author's review.