Repository navigation
Preserve completed Apple upload acknowledgements during cancellation - #1556
Merged
bmehta001 merged 1 commit intoNov 5, 2026
Merged
Conversation
Let an error-free, header-bounded HTTP 200 completion retain its response when cancellation is pending. Keep interrupted, failed, oversized and non-200 requests on the existing cancellation path; this does not solve lost acknowledgements or promise exactly-once delivery. Exercise the real response handler deterministically through a helper compiled only in Apple unit-test builds, without new shipping state. Files changed: - lib/http/HttpClient_Apple.mm - tests/unittests/HttpClientTests.cpp - tests/unittests/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f83491fd-5a6e-40af-b973-e83a3d7dad75
bmehta001
marked this pull request as ready for review
November 5, 2026 06:26
bmehta001
enabled auto-merge (squash)
November 5, 2026 06:29
Baiju Meswani (baijumeswani)
approved these changes
Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce avoidable duplicate uploads when cancellation races with an already completed Apple HTTP response. Related to #1542; this is a partial mitigation, not a resolution of the full issue.
Validation
HttpClientTests.*:HttpResponseDecoderTests.*passed.CompletedAppleResponseSurvivesPendingCancellation,PendingAppleCancellationDoesNotAcceptUnconfirmedResponses, andAppleResponseValidationWithoutCancellationIsUnchanged. Unit and functional XCTest suites also passed in that job: https://github.com/microsoft/cpp_client_telemetry/actions/runs/41979913757/job/127087389622Scope
This does not prevent duplicate ingestion after a lost acknowledgement or abrupt termination. Retrying ambiguous uploads remains intentional to avoid losing telemetry. Receiver-side idempotency/deduplication is still needed for that broader problem, which remains open.