fix(publish): close base channel over rpmlint and dpkg-perl deps - #18984
Open
Izan (IzanVil) wants to merge 1 commit into
Open
Izan (IzanVil) wants to merge 1 commit into
Izan (IzanVil) wants to merge 1 commit into
Conversation
rpmlint and dpkg publish to rpm-base, but some of their hard runtime
Requires are only built into rpm-sdk, so neither package can be
installed from the base repo. `dnf repoclosure` against the 4/preview
base repo reports:
dpkg-perl: perl(Digest::SHA1)
rpmlint: devscripts-checkbashisms, python3.14dist(pybeam),
python3.14dist(tomli-w)
Move the providing components, plus python-construct (required by
python3-pybeam), into base-packages so base holds the transitive
closure of its runtime dependencies, as the group documents.
Only devscripts-checkbashisms is needed from devscripts. Carve the
devscripts main package out to sdk through exceptions-packages, the
same pattern used for ShellCheck, so its perl/dpkg-dev tree stays out
of base.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: IzanVil <soyoquienmas@outlook.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The channel assignments are correctly scoped, sorted, and consistent with existing package-exception conventions.
Review effort: Balanced
Findings: None
What changed in this PR
Updates publish-channel assignments so rpmlint and dpkg-perl have complete runtime dependency closure in rpm-base.
Changes:
- Moves five required dependency components into
rpm-base. - Keeps the unnecessary
devscriptsmain package inrpm-sdk.
| File | Description |
|---|---|
base/comps/components-publish-channels.toml |
Adds base dependencies and the devscripts package exception. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rpmlintanddpkg-perlare published torpm-base, but some of their hard runtimeRequiresare only built intorpm-sdk, so neither can be installed from the base repo.dnf repoclosure --newestagainsthttps://packages.microsoft.com/azurelinux/4/preview/base/x86_64reports:base-packagesis documented as holding "the transitive closure of their runtime dependencies", so these providers belong in base. (rpmlintmoved to base in #18393; its deps did not follow.)Change
Add to
base-packages:perl-Digest-SHA1perl(Digest::SHA1)dpkg-perlpython-pybeampython3-pybeamrpmlintpython-constructpython3-constructpython3-pybeam(construct >= 2.9, < 2.11)python-tomli-wpython3-tomli-wrpmlintdevscriptsdevscripts-checkbashismsrpmlintOnly the small
devscripts-checkbashismssub-package is needed fromdevscripts, so thedevscriptsmain package (Debian helper scripts with a large perl / dpkg-dev dependency tree) is carved back out to sdk viaexceptions-packages— the same pattern already used forShellCheck.The remaining deps of the moved packages are already in base (
python3-six,perl-libs,perl-File-Temp,perl-Getopt-Long,perl-Test-Harnessforperl-Digest-SHA1-tests).Verification
azldev config dumppasses.azldev package list --rpm-fileresolves:devscripts-checkbashisms,perl-Digest-SHA1,perl-Digest-SHA1-tests,python3-construct,python3-pybeam,python3-tomli-w→rpm-base;devscripts→rpm-sdk(exceptions-packages); thedevscriptsSRPM →rpm-base-srpm.azldev comp updateon the five components produces no lock changes (publish channel is not a render input), so no spec re-render is needed.rubygem-rdoc-doc6.4.0 requiringrubygem-rdoc = 6.4.0whilerubyprovides a newerrubygem-rdoc) is inherited from Fedora 43 as-is and is left untouched here.🤖 Generated with Claude Code