repro: stress worktree mount diagnostics - #2120
Draft
Tyrie Vella (tyrielv) wants to merge 1 commit into
Draft
Tyrie Vella (tyrielv) wants to merge 1 commit into
Tyrie Vella (tyrielv) wants to merge 1 commit into
Conversation
Repurpose the draft PR as a focused repro for the concurrent worktree mount failure. Keep the worktree mount assertion strict, but expand failure diagnostics to include worktree gitdir state, hook/log directories, and recent per-worktree mount logs. Log every hook-side gvfs mount attempt failure, then run only WorktreeTests across repeated functional-test matrix jobs to improve repro chances. Assisted-by: GitHub Copilot Auto Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Tyrie Vella (tyrielv)
force-pushed
the
tyrielv/fix-concurrent-worktree-flake
branch
from
September 24, 2026 22:41
bfea2b4 to
b64a4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Context
ConcurrentWorktreeAddCommitRemoveintermittently fails because a linked worktree exists, but its worktree-specific GVFS mount pipe is not running.This PR is a repro and diagnostics branch. It does not try to fix the product path yet. The goal is to collect enough evidence from PR validation to distinguish a mount-process failure from a timing issue, and to capture the per-worktree admin directory state when the failure occurs.
Changes
.gitfile, resolved worktree git dir, hook directory,.gvfsdirectory, and recent per-worktree mount logs.gvfs mountretry failure with exit code, stdout, and stderr.GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WorktreeTestsin every matrix job.This is intentionally temporary. The workflow change should be reverted when we replace this with the product fix.