Skip to content

repro: stress worktree mount diagnostics - #2120

Draft
Tyrie Vella (tyrielv) wants to merge 1 commit into
microsoft:masterfrom
tyrielv:tyrielv/fix-concurrent-worktree-flake
Draft

Tyrie Vella (tyrielv) wants to merge 1 commit into
microsoft:masterfrom
tyrielv:tyrielv/fix-concurrent-worktree-flake

Conversation

@tyrielv

@tyrielv Tyrie Vella (tyrielv) commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Problem and Context

ConcurrentWorktreeAddCommitRemove intermittently fails because a linked worktree exists, but its worktree-specific GVFS mount pipe is not running.

This PR is a repro and diagnostics branch. It does not try to fix the product path yet. The goal is to collect enough evidence from PR validation to distinguish a mount-process failure from a timing issue, and to capture the per-worktree admin directory state when the failure occurs.

Changes

  • Keep the worktree mount assertion strict. A missing worktree pipe still fails the test.
  • Add failure diagnostics for the worktree .git file, resolved worktree git dir, hook directory, .gvfs directory, and recent per-worktree mount logs.
  • Log every hook-side gvfs mount retry failure with exit code, stdout, and stderr.
  • Change functional-test validation for this repro PR to run only GVFS.FunctionalTests.Tests.EnlistmentPerFixture.WorktreeTests in every matrix job.
  • Keep the repeated matrix shape so CI runs the worktree tests many times on both x64 and arm64.

This is intentionally temporary. The workflow change should be reverted when we replace this with the product fix.

Repurpose the draft PR as a focused repro for the concurrent worktree mount failure.

Keep the worktree mount assertion strict, but expand failure diagnostics to include worktree gitdir state, hook/log directories, and recent per-worktree mount logs.

Log every hook-side gvfs mount attempt failure, then run only WorktreeTests across repeated functional-test matrix jobs to improve repro chances.

Assisted-by: GitHub Copilot Auto

Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
@tyrielv Tyrie Vella (tyrielv) changed the title test: recover concurrent worktree mount flake repro: stress worktree mount diagnostics Sep 24, 2026
@tyrielv
Tyrie Vella (tyrielv) force-pushed the tyrielv/fix-concurrent-worktree-flake branch from bfea2b4 to b64a4a4 Compare September 24, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant