Update @webref/idl to version 3.82.1 by Bashamega · Pull Request #2535 · microsoft/TypeScript-DOM-lib-generator

Adam Naji (Bashamega) · 2026-08-30T16:53:44Z

github-actions · 2026-08-30T16:53:58Z

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

Kagami Sascha Rosylight (saschanaz) · 2026-08-30T18:11:51Z

 declare var ProcessingInstruction: {
    prototype: ProcessingInstruction;
-    new(): ProcessingInstruction;
+    new(target: string, data?: string): ProcessingInstruction;


This is not supported by anyone I believe, we'll have to also remove this in KDL.

I have fixed it and added support for it in kdl

…s multiple TypeScript definition files and update related handling in patches.

Kagami Sascha Rosylight (saschanaz) · 2026-08-31T19:24:02Z

-  optional?: boolean;
-  variadic?: boolean;
-}
+export type Param =


Can you do it without changing types.ts? Patching should not change base types unless the type is already wrong.

…ting Param interface for improved flexibility in method signatures.

Kagami Sascha Rosylight (saschanaz) · 2026-09-01T15:19:08Z

+        ) {
+          params.push(param.name);
+        } else {
+          params.push(param);


It's better, but still kinda sad. I wonder it would be better to somehow treat { name: "foo" } with no other fields as foo on prune() level. If that's possible then we won't need this workaround for any future array items either. Thoughts?

…es.ts for improved type safety and clarity.

…d maintainability.

Adam Naji (Bashamega) · 2026-09-01T15:52:19Z

I have improved the logic Kagami Sascha Rosylight (@saschanaz)

Kagami Sascha Rosylight (saschanaz)

Thanks! I'll need to double check other changes, but the logic patch looks really good 🙏🏻👍🏻🎉

Kagami Sascha Rosylight (saschanaz) · 2026-09-01T15:59:16Z

+          Object.keys(item).length === 1 &&
+          Object.prototype.hasOwnProperty.call(item, "name") &&
+          typeof (item as Record<string, unknown>).name === "string",
+      )


Can you extract this lambda in every() into a separate function so that it becomes obj.every(isObjectWithOnlyName) (name free to change)?

Thanks for the learning, I have updated it

Introduced isObjectWithOnlyName function to streamline checks for objects with a single 'name' property. Updated convertForRemovals to utilize this new helper for improved readability and maintainability.

Kagami Sascha Rosylight (saschanaz) · 2026-09-01T16:04:48Z

@@ -0,0 +1,5 @@
+removals {
+    dictionary WheelEventInit {
+        member momentum // Blink only as of 2025-08


2025 or 2026? 👀

LOL, this was a typo, updated

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

Kagami Sascha Rosylight (saschanaz) · 2026-09-01T16:21:29Z

Now about the compiler test failure.

--- FAIL: TestLocal (2.34s)
    --- FAIL: TestLocal/globalThisBlockscopedProperties.ts (0.02s)
        --- FAIL: TestLocal/globalThisBlockscopedProperties.ts/type (0.00s)
            baseline.go:79: the baseline file /home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/TypeScript/tsc/testdata/baselines/reference/conformance/globalThisBlockscopedProperties.types has changed. (Run `hereby baseline-accept` if the new baseline is correct.)
    --- FAIL: TestLocal/mappedTypeRecursiveInference.ts (0.15s)
        --- FAIL: TestLocal/mappedTypeRecursiveInference.ts/type (0.12s)
            baseline.go:79: the baseline file /home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/TypeScript/tsc/testdata/baselines/reference/compiler/mappedTypeRecursiveInference.types has changed. (Run `hereby baseline-accept` if the new baseline is correct.)

Jake Bailey (@jakebailey), this is the first time I've seen this test failing. I don't understand why it fails because no line change happened, and the test file looks very simple. what do we do? Ignore it?

Update @webref/idl to version 3.82.1

fc8ff9a

Kagami Sascha Rosylight (saschanaz) reviewed Aug 30, 2026

View reviewed changes

Refactor ProcessingInstruction constructor to remove parameters acros…

0e9dd1d

…s multiple TypeScript definition files and update related handling in patches.

Kagami Sascha Rosylight (saschanaz) reviewed Aug 31, 2026

View reviewed changes

Enhance type definitions by introducing OverridableSignature and upda…

01a5bce

…ting Param interface for improved flexibility in method signatures.

Kagami Sascha Rosylight (saschanaz) reviewed Sep 1, 2026

View reviewed changes

Adam Naji (Bashamega) added 3 commits September 1, 2026 18:49

Refactor OverridableMethod and update handling of parameters in patch…

abe5380

…es.ts for improved type safety and clarity.

Refactor parameter handling in patches.ts for improved readability an…

3cc5da8

…d maintainability.

-

eb80005

Kagami Sascha Rosylight (saschanaz) reviewed Sep 1, 2026

View reviewed changes

Add helper function to check object structure in patches.ts

46f1bad

Introduced isObjectWithOnlyName function to streamline checks for objects with a single 'name' property. Updated convertForRemovals to utilize this new helper for improved readability and maintainability.

Kagami Sascha Rosylight (saschanaz) reviewed Sep 1, 2026

View reviewed changes

Adam Naji (Bashamega) and others added 3 commits September 1, 2026 19:06

fix year

cf7c09f

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

Add newline at end of dom.kdl file

52207bc

Remove momentum member from WheelEventInit dictionary

d273d75

Navigation Menu

Uh oh!

Update @webref/idl to version 3.82.1 - #2535

Update @webref/idl to version 3.82.1#2535
Adam Naji (Bashamega) wants to merge 10 commits into
microsoft:mainfrom
Bashamega:feat/bump-idl

Adam Naji (Bashamega) commented Aug 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) Aug 30, 2026

Uh oh!

Adam Naji (Bashamega) Aug 31, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) Aug 31, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) Sep 1, 2026

Uh oh!

Adam Naji (Bashamega) commented Sep 1, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) left a comment

Uh oh!

Kagami Sascha Rosylight (saschanaz) Sep 1, 2026

Uh oh!

Adam Naji (Bashamega) Sep 1, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) Sep 1, 2026

Uh oh!

Adam Naji (Bashamega) Sep 1, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Adam Naji (Bashamega) commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Adam Naji (Bashamega) commented Sep 1, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Adam Naji (Bashamega) commented Aug 30, 2026 •

edited

Loading