fix(mine): fallback to test when both train and val are empty in assign_splits - #278
Closed
RohithPariki wants to merge 1 commit into
Closed
fix(mine): fallback to test when both train and val are empty in assign_splits#278RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
assign_splitsinskillopt_sleep/mine.pyonly reaches intotrain(to top upval) or fromval(to top uptrain). If all real tasks hash into test, val and train start empty, and both guarantees no-op, causing the holdout gate to have no tasks.Root Cause
The
_promote_one(to="val", from_splits={"train"})call when val is empty silently fails if train is also empty.Solution
Added a fallback to promote one from
testwhen bothtrainandvalare empty, and logged a warning forholdout_leaked.Testing
Tested manually by running the tests.
Risk
Low risk, only triggers in the pathological case when train and val are both empty.
Issue
Closes #271