Repository navigation
Parse nested rule Operator case-insensitively in RuleCompiler to match RuleValidator - #759
Merged
YogeshPraj merged 1 commit intoNov 3, 2026
Conversation
YogeshPraj
approved these changes
Nov 3, 2026
YogeshPraj
enabled auto-merge (squash)
November 3, 2026 10:45
YogeshPraj
added a commit
that referenced
this pull request
Nov 4, 2026
#759 re-saved RuleCompiler.cs without its UTF-8 BOM. Restore it so the file matches its original encoding; no other change. Co-authored-by: MBrekhof <martin.brekhof@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: YogeshPraj <yoprajap@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RuleValidatorvalidatesrule.OperatorusingEnum.TryParse<ExpressionType>(op, true, out _)(case-insensitive, allowing"and","or","andalso","orelse"), whereasRuleCompiler.GetDelegateForRulecallsEnum.TryParse(rule.Operator, out ExpressionType nestedOperator)withoutignoreCase: true.As a result, a nested rule with
"Operator": "and"or"Operator": "or"passes validation without errors, failsEnum.TryParseduring compilation, and falls into the defaultInvalidOperationException($"{rule.Operator} is not supported")branch.Solution
ignoreCase: truetoEnum.TryParse(rule.Operator, true, out ExpressionType nestedOperator)inRuleCompiler.GetDelegateForRule.test/RulesEngine.UnitTest/NestedOperatorCaseInsensitiveTest.csverifying lowercase"and"and"or"operators on nested rules.