Skip to content

Fix/prompt shield parser #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Joel (aspire488) wants to merge 2 commits into from
+14 −0
Closed

Fix/prompt shield parser #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
662d8a1
fix: preserve text after Prompt Shield documents
aspire488 Sep 27, 2026
594295f
test: cover Prompt Shield trailing document text
aspire488 Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyrit/prompt_target/prompt_shield_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ def _input_parser(self, input_str: str) -> dict[str, Any]:
user_prompt += contents[0]
else:
documents.append(contents[0])
user_prompt += contents[1]

return {"userPrompt": user_prompt, "documents": documents if documents else []}

Expand Down
13 changes: 13 additions & 0 deletions tests/unit/prompt_target/target/test_prompt_shield_target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,19 @@ async def test_prompt_shield_document_parsing(
assert result == sample_delineated_prompt_as_dict


def test_prompt_shield_document_parsing_preserves_text_between_and_after_documents(
promptshield_target: PromptShieldTarget,
):
input_str = "q1 <document> d1 </document> q2 <document> d2 </document> q3"

result = promptshield_target._input_parser(input_str)

assert result == {
"userPrompt": "q1 q2 q3",
"documents": [" d1 ", " d2 "],
}


async def test_prompt_shield_response_validation(promptshield_target: PromptShieldTarget):
# This tests handling both an empty request and an empty response
promptshield_target._validate_response(request_body={}, response_body={})
Expand Down