Fix: exact text matching empty target - #2882
Merged
Roman Lutz (romanlutz) merged 5 commits intoSep 28, 2026
Merged
Roman Lutz (romanlutz) merged 5 commits into
Roman Lutz (romanlutz) merged 5 commits into
Conversation
Roman Lutz (romanlutz)
requested changes
Sep 28, 2026
Roman Lutz (romanlutz)
approved these changes
Sep 28, 2026
Contributor
Author
|
Thank you for reviewing and merging this! Really appreciate the thoughtful feedback throughout the process. It’s been great contributing to PyRIT, and I’m looking forward to continuing to work on improvements and picking up more issues in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests and Documentation
Description
Fixes an edge case in "ExactTextMatching" where an empty or whitespace-only target could incorrectly produce a match.
Python treats an empty string as being contained in every string (""" in text"), so an empty target could result in a false positive. This is particularly relevant when matching values that may default to an empty string.
Changes
Related Issue
Closes #2881
Validation
Added unit tests covering:
Non-empty matching behavior remains unchanged.