MAINT: extract technique factory resolution into its own module - #2871
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
resolve_technique_factories, resolve_technique_factories_for_techniques and TechniqueResolutionError move from matrix_atomic_attack_builder to a new pyrit/scenario/core/technique_resolution module, so non-matrix scenario shapes can resolve techniques without importing the matrix builder (issue microsoft#2869). consumers and patch targets updated; resolution tests split into their own module with full parity. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracts technique factory resolution into pyrit/scenario/core/technique_resolution.py, per the discussion in #2869, so non-matrix scenarios can resolve techniques without importing the matrix builder.
64 scenario-core tests green, full scenario + backend suites pass (1403), ruff clean.