Repository navigation
Check positive warning options - #1279
Merged
Merged
Conversation
GCC or other compatible compiler always accepts unknown -Wno-* flags; thus, check_cxx_compiler_flag() never fails on them and is meaningless. There are two options to fix this: either remove the checks altogether, or check for positive -W flags and set the desired -Wno-* ones. This commit chooses the second approach.
Carson Radtke (carsonRadtke)
approved these changes
Sep 24, 2026
Carson Radtke (carsonRadtke)
left a comment
Carson Radtke (carsonRadtke)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the improvements!
Carson Radtke (carsonRadtke)
merged commit Sep 24, 2026
7f7bc59
into
microsoft:main
89 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC or other compatible compiler always accepts unknown -Wno-* flags; thus, check_cxx_compiler_flag() never fails on them and is meaningless. There are two options to fix this: either remove the checks altogether, or check for positive -W* flags and set the desired -Wno-* ones.
This commit chooses the second approach.