Repository navigation
Keep the Fluent typing indicator image after React 19 Strict Mode and Activity show - #6051
Merged
Merged
Conversation
added 6 commits
November 12, 2026 16:28
…de and after <Activity> hide and show
… of revoking them in an effect cleanup
…typing indicator tests
…eact-scroll-to-bottom keeps its styles
William Wong (compulim)
approved these changes
Nov 13, 2026
Eugene (OEvgeny)
marked this pull request as ready for review
November 13, 2026 01:47
Eugene (OEvgeny)
requested review from
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 13, 2026 01:47
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Fluent theme asset URL lifetime fix.
No open issues 🎉
What changed in this PR
Fixes broken Fluent theme typing indicator and livestream loader images when React 19 Strict Mode or <Activity> replays effect cleanup.
Changes:
- Creates and caches both sliding-dot image URLs on first use, keeping them for the page lifetime.
- Adds regression tests for image loading in Strict Mode and after an
<Activity>hide/show cycle. - Adds a changelog entry documenting the fix.
| File | Description |
|---|---|
packages/fluent-theme/src/components/assets/AssetComposer.tsx |
Shares lazily created asset URLs and removes cleanup-based revocation. |
.changelog/6051-fix-fluent-asset-urls.md |
Documents the Fluent typing indicator fix. |
__tests__/html2/react19/fluentTheme.typingIndicator.strictMode.html |
Checks that the image loads after Strict Mode effect replay. |
__tests__/html2/react19/fluentTheme.typingIndicator.activity.html |
Checks image loading before and after an Activity hide/show cycle. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
<Activity>, in PR #6051, by @OEvgenyDescription
AssetComposercreated the sliding dotsblob:URLs while rendering and revoked them in an effect cleanup, which Strict Mode and<Activity>run again without rendering. The URLs are now created on first use and kept for the page lifetime.Design
getDefaultTypingAnimationImageURL.tsin the default theme: the 2 SVGs are small and constant, and are ready on first render; creating them in an effect would need a second render.img-src data:in a Content Security Policy.Specific Changes
AssetComposer.tsx: create the 2 URLs once per page, remove the revoking effectsreact19/fluentTheme.typingIndicator.strictMode.html: the image loads in Strict Modereact19/fluentTheme.typingIndicator.activity.html: the image loads before hide and after show; no snapshots, as react-scroll-to-bottom loses its styles in both casesI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed