Repository navigation
Fix the Merge test results check on Ubuntu 26.04 runners - #6046
Merged
Merged
Conversation
Eugene (OEvgeny)
marked this pull request as ready for review
November 12, 2026 20:45
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 12, 2026 20:45
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The change suppresses inconsistency diagnostics, but coverage preservation still needs runtime validation with real unit/browser tracefiles under lcov 2.4, including function and branch totals.
No open issues 🎉
What changed in this PR
Updates the coverage-reporting workflow to address the “Merge test results” failure with lcov 2.4 on Ubuntu 26.04, without pinning the runner image.
Changes:
- Ignore inconsistent coverage data during merge, list, and summary steps.
- Replace deprecated
lcov_branch_coveragewithbranch_coverage. - Add a changelog entry documenting the CI fix.
| File | Description |
|---|---|
.github/workflows/pull-request-validation.yml |
Update lcov options for coverage merging and reporting. |
.changelog/6046-fix-ci-lcov-ubuntu-26.md |
Document the Ubuntu 26.04 coverage-check fix. |
Review effort: Balanced
William Wong (compulim)
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
Ubuntu 26.04 ships lcov 2.4, which rejects our unit test coverage as corrupt because Istanbul writes two functions named
observeActivity(an outer function and its inner generator share the name), so nolcov.infois produced and the list and summary steps fail too. The lcov steps now ignoreinconsistentdata and usebranch_coverageinstead of the deprecatedlcov_branch_coverage.Design
inconsistentworks with lcov 2.0 (Ubuntu 24.04) and 2.4 (Ubuntu 26.04), so the job does not depend on theubuntu-latestimage; pinningruns-on: ubuntu-24.04would only postpone it, and renaming the inner generators would break again on the next duplicate name.Specific Changes
pull-request-validation.yml, jobmerge-test-results:--rc branch_coverage=1 --ignore-errors inconsistent,inconsistenton the merge, list and summary stepsI have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed