Skip to content

Fix the Merge test results check on Ubuntu 26.04 runners - #6046

Merged
Eugene (OEvgeny) merged 3 commits into
mainfrom
OEvgeny/fix-ci-lcov-ubuntu-26
Nov 13, 2026
Merged

Eugene (OEvgeny) merged 3 commits into
mainfrom
OEvgeny/fix-ci-lcov-ubuntu-26

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the "Merge test results" check, which fails on every pull request since ubuntu-latest moved to Ubuntu 26.04.

Changelog Entry

Fixed

  • 👷🏻 Fixed the "Merge test results" check failing on Ubuntu 26.04 runners (lcov 2.4), in PR #6046, by @OEvgeny

Description

Ubuntu 26.04 ships lcov 2.4, which rejects our unit test coverage as corrupt because Istanbul writes two functions named observeActivity (an outer function and its inner generator share the name), so no lcov.info is produced and the list and summary steps fail too. The lcov steps now ignore inconsistent data and use branch_coverage instead of the deprecated lcov_branch_coverage.

Design

  • Ignoring inconsistent works with lcov 2.0 (Ubuntu 24.04) and 2.4 (Ubuntu 26.04), so the job does not depend on the ubuntu-latest image; pinning runs-on: ubuntu-24.04 would only postpone it, and renaming the inner generators would break again on the next duplicate name.

Specific Changes

  • pull-request-validation.yml, job merge-test-results: --rc branch_coverage=1 --ignore-errors inconsistent,inconsistent on the merge, list and summary steps

  • I have added tests and executed them locally

  • I have added .changelog/<PR#>-<slug>.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change suppresses inconsistency diagnostics, but coverage preservation still needs runtime validation with real unit/browser tracefiles under lcov 2.4, including function and branch totals.

No open issues 🎉

What changed in this PR

Updates the coverage-reporting workflow to address the “Merge test results” failure with lcov 2.4 on Ubuntu 26.04, without pinning the runner image.

Changes:

  • Ignore inconsistent coverage data during merge, list, and summary steps.
  • Replace deprecated lcov_branch_coverage with branch_coverage.
  • Add a changelog entry documenting the CI fix.
File Description
.github/​workflows/​pull-request-validation.yml Update lcov options for coverage merging and reporting.
.changelog/​6046-fix-ci-lcov-ubuntu-26.md Document the Ubuntu 26.04 coverage-check fix.

Review effort: Balanced

@OEvgeny
Eugene (OEvgeny) merged commit ad47bd0 into main Nov 13, 2026
46 checks passed
@OEvgeny
Eugene (OEvgeny) deleted the OEvgeny/fix-ci-lcov-ubuntu-26 branch November 13, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants