[Fixes4BC (neeleshsinghal)]

Fixes AB#656982

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

The simple Fixed Asset Card edits the posting group on the depreciation book, while a customized Fixed Asset List column reads the Fixed Asset record. This change copies the validated book group into the card's source record so saving the card also updates the value used by the list.

The existing book validation still runs before the copy, including the rules for changes after acquisition. The five functional page copies apply the same change; the RU page has formatting changes only. The reported existing-book mismatch is addressed, but the unconditional copy introduces a separate no-book inconsistency.

Problem-solution fit

Fit: Strong

The change targets the two different stored values behind the reported card/list mismatch without changing posting calculations. It needs a small guard to preserve the existing behavior when no depreciation book can be saved.

Suggestions

S1 (🟠 Moderate): Skip master synchronization when no book exists
Only copy the group when a depreciation book can be saved. With a blank Depreciation Book Code, saving skips the book but persists this master value, so reopening the card shows blank while the list shows the new group. This also conflicts with the existing SetFAPostingGroupOnNewFixedAsset test.

Risk assessment and necessity

Risk: The regression surface is the simple-card posting-group edit in AT, FR, IT, NA, and W1. The change does not add ledger writes, change amounts, or alter public signatures or schemas; the book's existing financial safeguards still run first. The no-book case above can leave the card and master-based list inconsistent. No tests change, and the existing direct-edit test checks only the book rather than both persisted values. No runtime tests were run, and the failed build checks have no established link to this change.

Necessity: Without synchronization, permitted card edits leave the master-based list showing an old group even after refresh. Inspecting the depreciation book avoids relying on the stale list value, but changing the subclass is not a safe general workaround. The narrow synchronization fix is justified, with the no-book behavior preserved.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=13340 round=1 by=alexei-dobriansky at=2026-10-28T08:43:34.3915776Z lastSha=efb5b6c0f419bd6e902008417a3fa6bbbc3f78ce reviewKey=4d8558f7ada2851d336b9b976e811da9812fa83da84904c091799d087d2ac2cd suggestions=S1@232c5c51

[alexei-dobriansky]

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

The simple Fixed Asset Card now copies a validated depreciation-book posting group to the Fixed Asset record, keeping a master-based list column in sync after a permitted edit. The latest change adds the missing nonblank Depreciation Book Code guard in all five functional page copies. This matches the book persistence condition, preserves the existing no-book behavior, and leaves the book validation and acquisition safeguards before synchronization. The only previous finding is addressed; no new defect was found in the incremental change.

Status of previous suggestions

ID	Title	Status	Response / evidence
S1	Skip master synchronization when no book exists	Addressed	All five functional page copies now require a nonblank Depreciation Book Code before copying the posting group to the Fixed Asset record. This matches the book save condition and preserves the existing test expectation that editing the group without a book leaves the master group blank.

New observations (commits since round 1)

None - see the status of previous suggestions above.

Risk assessment and necessity

Risk: The regression surface is posting-group edits on the simple Fixed Asset Card in AT, FR, IT, NA, and W1. The guard preserves the blank-book case while retaining synchronization for a selected book; it changes no amounts, ledger writes, schemas, or public signatures. The existing no-book page test explicitly expects the master group to remain blank, matching the guarded code. This was static review only; no builds or runtime tests were run.

Necessity: Without synchronization, a permitted posting-group edit updates the depreciation book but leaves a list column based on the Fixed Asset record showing its previous value. The guard is needed to avoid creating a separate card/list mismatch when no depreciation book is selected. The scope is a narrow correction to the same edit path.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=13340 round=2 by=alexei-dobriansky at=2026-10-28T14:16:04Z lastSha=20119f684cdac80d00d1b993f993f15ce0e110ed reviewKey=a4c015e6d1d30982cd891760b894b9ae025eef96bcc9a5833803b091e8c70ce3 suggestions=S1@232c5c51:addressed parentRound=1