[Jatin Kumar (Explorer986)]

What & why

Hides VAT posting fields on Item Template, G/L Account Card, and Customer/Vendor templates when VAT in Use is off on General Ledger Setup. Also aligns template VAT pricing fields with their master cards. Sales-tax fields stay available.

Linked work

Fixes AB#651351

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

Risk & compatibility

NA-only visibility changes. No data, posting, schema, or W1 behavior changes.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

This change hides VAT posting groups on item, customer, and vendor templates and the G/L Account Card according to VAT in Use, while leaving sales-tax fields available. It also aligns template VAT price fields with their master cards.

The changed pages use the same General Ledger Setup visibility pattern as the corresponding master cards, and the tests cover both VAT states. The main scenarios are handled correctly, but the equivalent Resource Card remains inconsistent.

Problem-solution fit

Fit: Partial

The confirmed pages are fixed and the stored VAT values remain unchanged. The requested audit is incomplete because Resource Card still exposes its VAT posting field when VAT is disabled.

Suggestions

S1 (🟠 Moderate): Resource Card still exposes VAT setup
Apply the same VAT in Use visibility guard to Resource Card and add it to this test. That page still shows VAT Prod. Posting Group next to Tax Group Code when VAT is disabled, so the reported localization gap remains on an equivalent master-data page.

Risk assessment and necessity

Risk: The implementation changes UI visibility only. It does not modify stored values, posting logic, schema, public APIs, or events. Regression risk is limited to field discoverability, but Resource Card remains inconsistent in the same US sales-tax setup.

Necessity: The change is needed to avoid irrelevant VAT configuration and a misleading mandatory field. The scope is targeted, but it should include Resource Card to complete the master-data audit.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=13177 round=1 by=alexei-dobriansky at=2026-10-22T19:29:30Z lastSha=b4da8a8b4ead446ec58ad8acff5bde1ab7457542 reviewKey=2ffdd4b2baf1aaf06a1d841faafac827dd78e4da6840331fffed3a792b73a165 suggestions=S1@86df8f37

[alexei-dobriansky]

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

The new commit adds the same VAT in Use visibility guard to the Resource Card and extends the regression tests for both VAT states. Tax Group Code remains visible for sales tax, and reopening the card does not clear the stored VAT posting group.

Status of previous suggestions

ID	Title	Status	Author response
S1	Resource Card still exposes VAT setup	Addressed	Implemented in b10f53d

New observations (commits since round 1)

None - the new commit addresses the previous suggestion without introducing another issue.

Risk assessment and necessity

Risk: The change only controls page-field visibility. It does not change stored values, posting logic, schema, public APIs, or events. The added tests cover the Resource Card with VAT enabled and disabled and verify that the stored VAT posting group is preserved.

Necessity: This follow-up completes the equivalent master-data page audit and keeps the Resource Card consistent with the other North American cards.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=13177 round=2 by=alexei-dobriansky at=2026-10-23T01:05:42Z lastSha=b10f53dbf75d22c5180bb4e9949f1f4f18717869 reviewKey=93d78313b45629f9a6957c0695db7a92ae343c2300233ee0857d7f27732c33ac suggestions=S1@86df8f37:addressed parentRound=1

[alexei-dobriansky]

Good Sense Reviewer - Round 3

Recommendation: Accept

What this PR does

The current change hides VAT-only setup fields when VAT is disabled, keeps sales-tax fields available, and aligns VAT pricing fields with the corresponding master cards. The latest commit only updates the price-visibility test to open, verify, and close each template page in turn; it does not change production behavior and improves test isolation.

Status of previous suggestions

ID	Title	Status	Author response
S1	Resource Card still exposes VAT setup	Addressed	The Resource Card visibility guard and its regression coverage remain in the current diff.

New observations (commits since round 2)

None - the latest commit only changes test-page sequencing and introduces no new issue.

Risk assessment and necessity

Risk: The production change only controls page-field visibility. It does not change stored values, posting logic, schema, public APIs, or events. The latest test-only adjustment reduces overlap between open test pages without changing the scenarios being verified.

Necessity: The change is needed to avoid irrelevant VAT setup in sales-tax companies. The current scope covers the reported pages and equivalent template and master-data pages, while preserving the sales-tax fields.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=13177 round=3 by=alexei-dobriansky at=2026-10-23T07:04:00Z lastSha=55ee4979daf9f7b6b7cad2055bb3bafed028ffe2 reviewKey=ba9d29577d52deb5beaab226d2d9a04386fcdc92393d68c1d238ea018059a498 suggestions=S1@86df8f37:addressed parentRound=2