[Event Change Request] Codeunit 5900 "Service Header" - OnValidateShipToCodeOnBeforeDeleteLines() #30423

Activity

1. Steffan Crook (auzscr)

   added the

   Task

   issue type on Aug 15, 2026
2. Steffan Crook (auzscr)

   changed the title [-][Event Change Request] 5900 "Service Header" - OnValidateShipToCodeOnBeforeDeleteLines()[/-] [+][Event Change Request] Codeunit 5900 "Service Header" - OnValidateShipToCodeOnBeforeDeleteLines()[/+] on Aug 15, 2026
3. github-actions

   added

   missing-infoThe issue misses information that prevents it from completion.The issue misses information that prevents it from completion.

   on Aug 15, 2026
4. github-actions commented on Aug 15, 2026

   

   github-actionsBot

   on Aug 15, 2026 – with GitHub Actions

   Contributor

   More actions

   Hi Steffan Crook (@auzscr),

   Thank you for your extensibility request. To help us process it efficiently, please update the issue to include the required information.

   📚 Extensibility Guidelines

   Missing Information:

   • Previous-record (xServiceHeader) justification: Please explicitly confirm and justify why this event needs an xRec-style previous-record parameter so subscribers can rely on previous-record semantics in this event context.

   Please update the issue with the missing details. We'll automatically re-analyze once updated.

   Note

   Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

   Tip

   Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.
5. auzscr commented on Aug 17, 2026

   

   Steffan Crook (auzscr)

   on Aug 17, 2026

   Author

   More actions

                   IsHandled := false;
   				//
                   //OnValidateShipToCodeOnBeforeDeleteLines(Rec, IsHandled);
   				OnValidateShipToCodeOnBeforeDeleteLines(Rec, xRec, IsHandled);
   				//
                   if not IsHandled then
                       if ("Ship-to Code" <> xRec."Ship-to Code") and
                          ("Customer No." = xRec."Customer No.") and
                          ServItemLineExists()
                       then begin
                           Modify(true);
                           ServLine.LockTable();
                           ServItemLine.LockTable();
                           ServLine.Reset();
                           ServLine.SetRange("Document Type", "Document Type");
                           ServLine.SetRange("Document No.", "No.");
                           ServLine.DeleteAll(true);
                           ServItemLine.Reset();
                           ServItemLine.SetRange("Document Type", "Document Type");
                           ServItemLine.SetRange("Document No.", "No.");
                           ServItemLine.DeleteAll(true);
                       end;
   

   I have to check value for other custom fields and check if I need to handle the code. Thats why I need the xRec so see if it has changed.
6. github-actions

   added

   SCMGitHub request for SCM areaGitHub request for SCM area

   event-requestRequest for adding an eventRequest for adding an event

   and removed

   missing-infoThe issue misses information that prevents it from completion.The issue misses information that prevents it from completion.

   on Aug 17, 2026
7. github-actions commented on Aug 17, 2026

   

   github-actionsBot

   on Aug 17, 2026 – with GitHub Actions

   Contributor

   More actions

   ✅ Analysis complete - ready for further processing

   ---

   Implementation:

   Update the OnValidateShipToCodeOnBeforeDeleteLines integration event in Service Header to include xServiceHeader and pass xRec from the caller.

   Location in OnValidate("Ship-to Code") logic:

                   IsHandled := false;
                   OnValidateShipToCodeOnBeforeValidateServiceZoneCode(Rec, IsHandled);
                   if not IsHandled then
                       Validate("Service Zone Code");
   
                   IsHandled := false;
                   OnValidateShipToCodeOnBeforeDeleteLines(Rec, IsHandled, xRec);
                   if not IsHandled then
                       if ("Ship-to Code" <> xRec."Ship-to Code") and
                          ("Customer No." = xRec."Customer No.") and
                          ServItemLineExists()
                       then begin

   Event Publisher (add at the end of the codeunit with other events):

       [IntegrationEvent(false, false)]
       local procedure OnValidateShipToCodeOnBeforeDeleteLines(var ServiceHeader: Record "Service Header"; var IsHandled: Boolean; xServiceHeader: Record "Service Header")
       begin
       end;

   ---

   File: ServiceHeader.Table.al

   Note

   Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

   Tip

   Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.
8. Marko Aleksandric (AleksandricMarko)

   added

   ext-ready-to-implementReviewed and ready to implement and create PRReviewed and ready to implement and create PR

   on Aug 19, 2026
9. AleksandricMarko commented on Sep 1, 2026

   

   Marko Aleksandric (AleksandricMarko)

   on Sep 1, 2026

   Contributor

   More actions

   Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
10. Marko Aleksandric (AleksandricMarko)

    closed this as completedon Sep 1, 2026