Repository navigation
fix: recognize Copilot CLI and App MCP tool calls - #374
Open
alexcastgonz (pcbeingused333) wants to merge 2 commits into
Open
alexcastgonz (pcbeingused333) wants to merge 2 commits into
alexcastgonz (pcbeingused333) wants to merge 2 commits into
Conversation
github-actions
Bot
requested review from
TamasBoncz,
Aymen (aymenfurter) and
Sanjay Singh (san360)
November 8, 2026 19:03
Aymen (aymenfurter)
approved these changes
Nov 9, 2026
Contributor
Author
|
Friendly ping: this one is approved and CI is in place — happy to rebase or adjust anything if that helps get it merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #333 (gap 3: MCP tools in Copilot CLI/App; gap 1 stays open, so this does not close the issue).
Copilot CLI and App identify MCP calls through
tool.execution_start.data.mcpServerName, while context-engineering checks recognize themcp_tool-name prefix. The parser discarded the server metadata, so MCP usage was counted as missing.Normalize server-backed tool names to
mcp_<server>_<tool>when recording tools, removing the raw name previously recorded by assistant tool requests so each MCP tool is counted once. Built-in names and already-prefixed MCP names retain their existing representation. Increment the parsed-cache version so existing sessions are reparsed with the corrected MCP signal. This change covers gap 3 only; the custom-agent signal in gap 1 remains separate.Testing
Add a regression covering Copilot CLI and App through both synchronous and streaming parsers. It checks normalized MCP names, unchanged built-ins, empty server metadata, and one fewer missing context-engineering signal compared with the same requests without MCP usage.
npm test -- src/core/parser-vscode-cli.test.ts: 2 failing without the parser change, 20/20 passing with it. The fixture includes both assistant tool requests and execution events, checks a single normalized name, and verifies that the dashboard extracts thegithubserver ID.npm run checkpassed typecheck, lint, spellcheck, knip and lockfile-lint. The full suite finished with 3684 passed, 5 skipped and 8 failures in GitHub App analytics and Xcode tests because thesqlite3executable is missing from the test environment.git diff --checkpassed.AI assistance: this change and its regression tests were prepared using Codex.