Repository navigation
ci: test against ruby 3.3 and 3.4 - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The matrix tested a single Ruby version while the gemspec declares
required_ruby_version = ">= 3.2.0". Nothing was proving the gem worked on anything newer than the one pinned version.That gap became concrete: TroutRadar, which depends on this gem, now runs Ruby 3.4.2 in production. The gem does work there — but CI was not the thing telling us so.
Change
fail-fast: falseso one version breaking still reports the result for the others — otherwise a 3.4 failure hides whether 3.2 and 3.3 are fine, which is the main thing a matrix is for.The floor moved from an exact patch (
3.2.0/3.2.2) to'3.2', which resolves to the latest 3.2.x. That matches the gemspec's>= 3.2.0rather than pinning a patch release that ages out.Verified locally before adding
Both new versions were run before being added to CI, so this is not asking CI to discover something untested:
🤖 Generated with Claude Code