Repository navigation
Conversation
The test setup can leave one extra packet in the queue, so these ASICs may forward one packet fewer and drop one more.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test setup can leave one extra packet in the queue, so these ASICs may forward one packet fewer and drop one more.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
AgentAqmTest.verifyWredThresholdbuilds a queue and then checks how many packets are forwarded and how many are dropped. Because of the test setup, a looped-back packet is enqueued on the egress port before it is dropped. That packet occupies one buffer, so one extra packet is dropped and one fewer packet is forwarded. The drop check already allows that variation. This change also accepts one fewer forwarded packet, along with the exact expected count, and only for Ebro, Yuba, and G202X. Sent packets still have to be fully accounted for as forwarded or dropped.Test Plan
AgentAqmTest.verifyWredThresholdwas manually tested and passes.