Repository navigation
Only require gcc12 on EL9 to unblock BGP GitHub CI - #1864
Closed
KevinYakar wants to merge 1 commit into
Closed
KevinYakar wants to merge 1 commit into
KevinYakar wants to merge 1 commit into
Conversation
Summary: X-link: meta/BGP#15 The BGP GitHub Actions workflow has failed on every run since it was added in July. It runs getdeps directly on an Ubuntu 24.04 runner, where `gcc12` cannot be resolved: `bgp` and `fboss` depend on it on every distro, but it only exists as an EL9 package, so getdeps aborts before building anything. Requiring `gcc12` only on EL9 matches `openr` and leaves the EL9 builds (internal BGP OSS CI and the FBOSS Docker image) unchanged. On Ubuntu the build uses the runner's default compiler. The workflow now also installs system packages first, since `openssl` can only come from the system and would otherwise be the next blocker. Differential Revision: D128386555
Contributor
|
@KevinYakar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128386555. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta/BGP#15
The BGP GitHub Actions workflow has failed on every run since it was added in July. It runs getdeps directly on an Ubuntu 24.04 runner, where
gcc12cannot be resolved:bgpandfbossdepend on it on every distro, but it only exists as an EL9 package, so getdeps aborts before building anything.Requiring
gcc12only on EL9 matchesopenrand leaves the EL9 builds (internal BGP OSS CI and the FBOSS Docker image) unchanged. On Ubuntu the build uses the runner's default compiler. The workflow now also installs system packages first, sinceopensslcan only come from the system and would otherwise be the next blocker.Differential Revision: D128386555