Repository navigation
test(core): capture how docusaurus serve handles files with a dot and encoded slashes (AI-assisted) - #12898
Merged
Conversation
… encoded slashes (AI-assisted) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
slorber
added
the
Argos
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
 |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
docusaurus servetests capture folders with a dot in their name, but not files: this PR addsdocs/1.x.htmlto the fixture build, and captures the remaining edge cases before the stacked PRs fix them:trailingSlash: trueredirect, with or without abaseUrl:/base/docs/2.xservesdocs/2.x/index.htmldirectly, where/base/bothredirects to/base/both/. OurlooksLikeAssetregex and serve-handler both treat the dot as an extension.baseUrl: serve-handler decodes/base/%2F%2Ffileto//file, merges the slashes and redirects to/file, then the homepage.Files with a dot in their name are otherwise served like other files.
Test Plan
pnpm test packages/docusaurus/src/commands/serve: new snapshot rows and 3 edge case tests with aTODO fix.Test links
Deploy preview: https://deploy-preview-12898--docusaurus-2.netlify.app/
Related issues/PRs
docusaurus serveserves folders with a dot in their name (AI-assisted) #12896, which serves folders with a dot in their name(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit