Repository navigation
get_image_metadata(): add GIF support - #1791
Draft
NicolasHug wants to merge 1 commit into
Draft
NicolasHug wants to merge 1 commit into
NicolasHug wants to merge 1 commit into
Conversation
Probed in C++ with giflib: we walk the records like DGifSlurp() but skip the image data instead of LZW-decoding it. GIF has no frame count in its header so every data sub-block must be visited, which C++ does ~3x faster than Python on large animated GIFs. Paths go through a FileIO-backed reader (DGifOpenFileName opens files in text mode on Windows).
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1791
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit 52d04d7 with merge base ffb098a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probed in C++ with giflib: we walk the records like DGifSlurp() but skip the image data instead of LZW-decoding it. GIF has no frame count in its header so every data sub-block must be visited, which C++ does ~3x faster than Python on large animated GIFs. Paths go through a FileIO-backed reader (DGifOpenFileName opens files in text mode on Windows).
Stack created with GitHub Stacks CLI • Give Feedback 💬