[WC-3587]: Calendar - replace glyphicons with Atlas icons - #2444
Open
rahmanunver wants to merge 1 commit into
Open
rahmanunver wants to merge 1 commit into
rahmanunver wants to merge 1 commit into
Conversation
gjulivan
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Refactoring (e.g. file rename, variable rename, etc.)
Description
Replaces the legacy glyphicons on the Calendar toolbar's previous/next buttons with Atlas icons:
glyphicon-backward→mx-icon-filled mx-icon-controls-backwardglyphicon-forward→mx-icon-filled mx-icon-controls-forwardApplies to both the standard toolbar and the custom (configurable) toolbar.
IconInternalnow usestype: "icon"so theglyphiconbase class is no longer added. Added unit tests for both toolbars, and a CHANGELOG entry.Note: apps whose Atlas version doesn't include the
controls-*icons will show empty previous/next buttons.What should be covered while testing?