Skip to content

[MCC-1548828] Python Lib - Remove x-client-public-ip header from Python SDK Arrow Flight options [Dev Only] - #64

Open
glondhe-mdsol wants to merge 2 commits into
mainfrom
MCC-1548828
Open

[MCC-1548828] Python Lib - Remove x-client-public-ip header from Python SDK Arrow Flight options [Dev Only]#64
glondhe-mdsol wants to merge 2 commits into
mainfrom
MCC-1548828

Conversation

@glondhe-mdsol

@glondhe-mdsol glondhe-mdsol commented Sep 10, 2026

Copy link
Copy Markdown

refactor

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

Remove x-client-public-ip header from Python SDK Arrow Flight options

Deployment Notes

In addition to IAC/code, add any notes for reviewer should know.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Add an explicit test assertion that x-client-public-ip is absent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes x-client-public-ip header generation and socket-based IP discovery from the Python SDK Arrow Flight transport.

Changes:

  • Removes public IP header injection and related socket logic.
  • Removes obsolete IP-related tests and imports.
File summaries
File Reviewed change
tests/test_logging_headers.py Header coverage does not explicitly assert that x-client-public-ip is absent.
dataconnect/transport/arrow_flight/transport.py Removes socket-based IP header injection.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/test_logging_headers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants