Repository navigation
refactor(executor): move the executor out of internal/cmd into its own package - #20
Merged
Merged
Conversation
…n package pm work, pm run-epic, pm finish, the worker guard, the review policy and the pm executor commands - 26 files and their 38 test files - move with git mv to internal/executor. The package clause changes, and the five command constructors root.go registers are exported (NewWorkCmd, NewRunEpicCmd, NewFinishCmd, NewExecutorCmd, NewWorkerGuardCmd); nothing else is exported and no logic changes. internal/executor imports only storage and the leaf helper packages, never internal/cmd. Tests: cmd keeps its own copies of the small store/stdout helpers it used from the executor's test files (helpers_test.go); the root registration check and the `pm context` case of the unreadable project.yaml test stay in cmd, where those commands live.
mbalazy
changed the base branch from
refactor/extract-cli-shared-helpers
to
main
October 10, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #19.
internal/cmdheld the CLI and the executor together, and most of its lines were the executor. The executor's files and their tests now live ininternal/executor. That coverspm work,pm run-epic,pm finish,pm executor ..., thepm worker-guardhook and the review policy.internal/cmd/root.goregisters the five exported constructors (NewWorkCmd,NewRunEpicCmd,NewFinishCmd,NewExecutorCmd,NewWorkerGuardCmd).git diff -Mshows 64 renames. In the moved production code the only changes are the package clause and the five constructor names.internal/cmd(root_test.go,context_test.go).internal/cmd/helpers_test.goholds the test helpersinternal/cmd's own tests still need.cmd/pmimportsinternal/cmd, andinternal/executorimportsstorageplus the leaf packages from refactor: move the helpers the CLI and the executor share out of internal/cmd #19.docs/design-log.mdkeeps the old ones, because it records what was true then.