[hloeung]

Per 42wim/matterircd#945

[Copilot]

🟡 Changes recommended

Unsynchronized profile reads and formatting before timezone updates can cause races and incorrect cached expiry text.

2 open issues

• Hold Users lock while reading props and updating fallback status · New
• Apply updated timezone before formatting custom status · New

What changed in this PR

This PR synchronizes Mattermost custom statuses with cached user profiles, supporting the related matterircd status-update fix.

Changes:

• Refresh custom-status cache entries when user profiles change.
• Add a lock-aware helper for parsing and storing custom statuses.
• Recover missing formatted statuses from cached profile properties.

File	Description
users.go	Synchronizes custom statuses during profile updates and adjusts status lookup fallback logic.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Status lookups can restore an explicitly cleared custom status from stale cached profile properties.

1 open issue

• Preserve explicit empty custom status in cache · New

2 resolved since last review

• Hold Users lock while reading props and updating fallback status
• Apply updated timezone before formatting custom status

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The changes preserve the public API and consistently use the cache mutex, with no identified blocking issues.

No open issues 🎉

1 resolved since last review

• Preserve explicit empty custom status in cache

_{Review effort: Balanced}