Repository navigation
Address review feedback on initial draft; align logging with matterclient - #2
Merged
Merged
Conversation
Co-authored-by: hloeung <95021+hloeung@users.noreply.github.com>
Merged
Co-authored-by: hloeung <95021+hloeung@users.noreply.github.com>
…ing-and-fix-issues Co-authored-by: hloeung <95021+hloeung@users.noreply.github.com>
hloeung
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the six Copilot review comments on the initial draft (#1) and makes logging consistent with
matterclient, using logrus with thematterbridge/logrus-prefixed-formatter.Ready / handler serialization
Readyis no longer fired from a separate timer goroutine. AreadySyncerwrapper aroundDefaultSyncercalls it once, on the sync goroutine, after the first sync response has been fully processed.Ready,OnMessageandOnReactionserialized as theHandlercontract says.Direct rooms
SendDirectnow persists the updatedm.directaccount data viaSetAccountData. Previously the new room existed only in memory, so a relogin could create a duplicate.handleDMtreatsm.directas a full snapshot. It rebuildsdmChannelsand clearsIsDirecton rooms that were removed.DisplayNamedoesn't regress to empty.Rooms
Channeland maintain itsMembers, so unnamed joined rooms show up inRooms().Channelgets a separateNamefield.Rooms()resolves the alias first, then the name, then the room ID. Clearing the canonical alias no longer discards the room name.Logging
Newbuilds two logrus loggers with the prefixed formatter, as matterclient does:matrixclientwith padding 13.matrixclient: APIwith padding 18, at error level.go.modandgo.sum.