Repository navigation
MLE-32902: Fix SUID/SGID permissions on TPM eventlog - #491
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted fix is consistent across architectures and includes appropriate runtime validation.
0 open findings
What changed in this PR
Corrects UBI9 TPM eventlog permissions to remove SGID/SUID bits across x86 and ARM images.
Changes:
- Normalizes the tmpfiles rule to
0775. - Clears existing special permission bits.
- Adds a UBI9 smoke-test assertion.
| File | Description |
|---|---|
dockerFiles/marklogic-deps-ubi9:base |
Fixes x86 eventlog permissions. |
dockerFiles/marklogic-deps-ubi9-arm:base |
Applies the equivalent ARM fix. |
test/docker-tests.robot |
Verifies the eventlog has no SUID/SGID bits. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vitalykorolev
requested review from
barkhachoithani,
pengzhouml,
rwinieski and
sumanthravipati
October 8, 2026 20:17
barkhachoithani
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MLE-32902 by correcting permissions on
/run/tpm2-tss/eventlogand adding a smoke-test assertion.Root cause
The UBI9
tpm2-tss-fapitmpfiles rule creates the eventlog directory with mode2775, setting the SGID bit.Fix
Normalize the rule to
0775, clear existing SUID/SGID bits, and assert the running directory has no special bits.Validation
make lintpassed; Hadolint reported only DL3067/DL3064 warnings.0775, directory mode0775/775, and no SUID/SGID bits.