Repository navigation
Add ILINK002 duplicate-handler detection - #17
Merged
Merged
Conversation
Refactor MissingHandlerAnalyzer to detect and report duplicate request handlers (ILINK002) while retaining ILINK001 for missing handlers. Split diagnostics into MissingHandlerRule and DuplicateHandlerRule (MissingHandlerId / DuplicateHandlerId), build handlersByRequest to map request -> handlers, and report ILINK002 on each handler when more than one exists. Clean up symbol/type checks and collection usage; SupportedDiagnostics now includes both rules. Bump Interlink.Analyzers to 1.6.0. Update Interlink.Sample to consume the analyzer as a ProjectReference (OutputItemType="Analyzer", ReferenceOutputAssembly="false"), remove NuGet analyzer ref, add Microsoft.AspNetCore.OpenApi, and keep EF Core packages. Docs and samples: add ILINK002 to AnalyzerReleases.Shipped.md and README with example code, clarify ILINK001 example, and tweak release notes formatting. Move GetSomthing into its own sample file and add two handlers to intentionally trigger the duplicate-handler diagnostic. Minor XML comment and formatting fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor MissingHandlerAnalyzer to detect and report duplicate request handlers (ILINK002) while retaining ILINK001 for missing handlers. Split diagnostics into MissingHandlerRule and DuplicateHandlerRule (MissingHandlerId / DuplicateHandlerId), build handlersByRequest to map request -> handlers, and report ILINK002 on each handler when more than one exists. Clean up symbol/type checks and collection usage; SupportedDiagnostics now includes both rules.
Bump Interlink.Analyzers to 1.6.0. Update Interlink.Sample to consume the analyzer as a ProjectReference (OutputItemType="Analyzer", ReferenceOutputAssembly="false"), remove NuGet analyzer ref, add Microsoft.AspNetCore.OpenApi, and keep EF Core packages.
Docs and samples: add ILINK002 to AnalyzerReleases.Shipped.md and README with example code, clarify ILINK001 example, and tweak release notes formatting. Move GetSomthing into its own sample file and add two handlers to intentionally trigger the duplicate-handler diagnostic. Minor XML comment and formatting fixes.