fix: remove Reakit peer conflict with React 18-tested tooltip - #60
Merged
Merged
Conversation
Preserve trigger descriptions, refs, events and keyboard behavior. Add source unit and built-bundle browser regressions. Model: gpt-6-astra
Model: gpt-6-astra
mssteuer
requested review from
davidatwhiletrue,
eugenebelov and
victoriari
September 11, 2026 03:58
victoriari
approved these changes
Sep 17, 2026
mssteuer
marked this pull request as ready for review
September 17, 2026 16:41
Member
Author
|
Ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^18.3.0), child refs/events/name/existing description, null behavior, styling and contents; connect the previously ignored forwarded tooltip ref.Coordination with #42 — draft pending consolidation
I read the CLICK-908 diff and discussion before preparing this change. It overlaps this exact wrapper with a
react-tooltipmigration, but keeps Reakit in both package files, so it does not resolve the React 18 peer conflict as written. This draft is a peer-compatibility candidate using the closer successor APIs, not an unnoticed continuation of #42. Maintainers should choose/consolidate the approaches; do not merge both replacements independently. #42 and its branch are untouched.Verification
npm ci --legacy-peer-deps=false --strict-peer-deps: passed; actual React/DOM 18.3.1; no Reakit packages.npm test: 2 tests passed.npm run test:consumer: passed; real npm pack, isolated strict installation, no workspace symlink, production Vite bundle and 2 Chromium tests passed.Existing limitations / scope
window) fail on both untouched base and candidate. This PR verifies the existing browser/Vite target, not SSR support.Release gate — no release triggered
Registry latest is 2.0.6; master already declares unpublished 2.0.7. After review/consolidation and merge, publish 2.0.7 (or next available patch) through the existing GitHub release-triggered workflow. Then update application lockfile resolutions to the registry release and rerun strict install/build/browser checks. CSPR.click UI 1.12.1 declares design
^2.0.6, so it accepts 2.0.7 without a separate UI release, subject to verifying the actual application's locked version.Test instructions and caveats:
tests/README.md.Model: gpt-6-astra