Repository navigation
Enable headlights button based on LEDs state - #115
Closed
OakCityDirtyRandy wants to merge 1 commit into
Closed
OakCityDirtyRandy wants to merge 1 commit into
OakCityDirtyRandy wants to merge 1 commit into
Conversation
Fix: Disable the Headlights button unless LEDs are On.
Owner
You've got two spaces after the "Fix:" and by convetion there are no full stops at the end of the thing. I wanted to fix this in your PR but you've created it from Only after the fact I noticed there's also a double space in the actual changed line: There's no linter on the QML. Please try to pay attention, I don't want messy code. |
Owner
|
Oh, I also decided to change the Fix: to Feature:, as it's not a fix per se, it's more like a tiny feature. |
Contributor
Author
|
Sorry about the formatting. It's the tiniest Feature ever!
…On Sat, Oct 17, 2026, 07:49 Lukáš Hrázký ***@***.***> wrote:
*lukash* left a comment (lukash/refloat#115)
<#115 (comment)>
Oh, I also decided to change the Fix: to Feature:, as it's not a fix per
se, it's more like a tiny feature.
—
Reply to this email directly, view it on GitHub
<#115?email_source=notifications&email_token=BXIEQCQAV74LRJWSL6ZITDL5UNMGJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRTGM2TGNJSGYZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6233535262>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXIEQCSHN3UL6BPR3U3VZTD5UNMGJAVCNFSNUABFKJSXA33TNF2G64TZHM4DAOBXG43DONRQHNEXG43VMU5TKOBZGAZDGOJSGU4KC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Disable the Headlights button unless LEDs are On.