Repository navigation
Reverse stop: shorter distance and tighter target angle - #114
Merged
Merged
Conversation
The changes make reverse stop closer to how it behaved in v1.2 and earlier. Fix: Make reverse stop more beginner friendly again
Owner
|
LGTM, note I force-pushed a couple capitalization fixes to your remove branch. The only potential flaw I noticed while testing was when going back very slow. The reverse stop doesn't activate by design, but I found it quite inconsistent at which speed it actually activates. Seems sometimes I can slowly speed up quite a bit and then it's a surprise when it triggers. I assume this is not a regression and just a property of the discrete erpm changes which has likely been there with the 1.2 implementation too. I don't have an immediate solution so something for another day I guess. |
Contributor
Author
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes make reverse stop closer to how it behaved in v1.2 and earlier. Wife tested and approved (tested on Pint, Atom, XR, GT)
Fix: make reverse stop more beginner friendly again