Repository navigation
Anims banner mode - #113
Closed
OakCityDirtyRandy wants to merge 4 commits into
Closed
OakCityDirtyRandy wants to merge 4 commits into
OakCityDirtyRandy wants to merge 4 commits into
Conversation
Owner
|
Is this AI'd? 😬 It's not implemented correctly. Possibly open a discussion on discord. You're adding a config option to each strip and this config option only does something for the Solid animation mode. The proper way to do this is implement a new animation mode called "Banner" or potentially more descriptively "Solid Banner". Also, clean up the commits. I think this whole implementation can go into one (properly described) commit. |
Contributor
Author
|
Ugh. Sorry about that. Solid was my initial test. Ive set it up to work
with all the non-Rainbow animations and that's what *should* be in the PR.
I have been using Copilot in VScode recently, and while it has done alright
with code -- it types much faster than I do! -- it can make an absolute
mess of branches and commits. I finally told it to never commit anything.
😡 I'll clean all that up. I have tested this against every non-Rainbow
animation and they all work and sometimes look pretty cool.
I added Banner Mode to each strip so that people would have the flexibility
to use it selectively. I did not make it global across all lighting
because it makes no sense for status and it doesn't work well with
headlight configurations with dedicated headlights LEDs.
So, with those explanations:
Does Banner Mode make sense as a name? I'm not overly attached but I think
it describes the look. I can drop Mode but I think it describes a
different behavior.
Do I leave this as a per strip option or do I make it global?
Is there anything else I need to address?
Let me know and I'll set up a new branch and handle as a single commit then
send a new PR. Btw, I am still planning on testing Refloat Extras but have
had some trouble getting it onto a board. I'll figure it out.
Randy
…On Fri, Oct 16, 2026, 07:52 Lukáš Hrázký ***@***.***> wrote:
*lukash* left a comment (lukash/refloat#113)
<#113 (comment)>
Is this AI'd? 😬
It's not implemented correctly. Possibly open a discussion on discord.
You're adding a config option to each strip and this config option only
does something for the Solid animation mode. The proper way to do this is
implement a new animation mode called "Banner" or potentially more
descriptively "Solid Banner".
Also, clean up the commits. I think this whole implementation can go into
one (properly described) commit.
—
Reply to this email directly, view it on GitHub
<#113?email_source=notifications&email_token=BXIEQCRJL3IW2LUH5BBJOAL5UIDW7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRRGQ4DQOBWGM2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6214888634>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXIEQCTKVJT6LQSNYWODSPD5UIDW7AVCNFSNUABFKJSXA33TNF2G64TZHM4DAOBXG43DONRQHNEXG43VMU5TKNZWGYZDIMJRG4ZKC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Banner Mode is enabled, the LED strip is divided into three equal or nearly equal parts. Left and Right are the Primary color and Center is the Secondary. In Solid mode, this looks like a two-color banner. Non-rainbow animations work on top of this background.
So whether it's game day for your favorite team or you just want to unleash your inner Gryffindor, give it a try!
Note: Banner Mode works but not as well with LED strips that include dedicated bright white headlights.

BannerModePulse.mp4