Repository navigation
Disable Headlights button when LEDs/Lights not on - #106
Closed
OakCityDirtyRandy wants to merge 2 commits into
Closed
OakCityDirtyRandy wants to merge 2 commits into
OakCityDirtyRandy wants to merge 2 commits into
Conversation
Owner
|
I'm fine with this. FWIW to give some unasked-for context, the buttons in the Control tab are kind of stop-gap, I wanted to do a generic "quick toggle" bar in the UI for which you'd be able to pick buttons, the two LED buttons would be part of that. Could you just add a changelog line to the commit message? The convention is described in
You'll get the attribution in the changelog too. |
Owner
|
You've added a merge commit to the PR branch, that shouldn't be there. I use a rebase workflow, if you want to get the latest |
Contributor
Author
|
I was trying to get a trailer in there and neglected to use force. Let me
try and fix that.
…On Fri, Oct 16, 2026, 15:25 Lukáš Hrázký ***@***.***> wrote:
*lukash* left a comment (lukash/refloat#106)
<#106 (comment)>
You've added a merge commit to the PR branch, that shouldn't be there. I
use a rebase workflow, if you want to get the latest main branch in, you
need to rebase your branch on top of it and (force) push that to the PR
branch.
—
Reply to this email directly, view it on GitHub
<#106?email_source=notifications&email_token=BXIEQCXMH64KTI4I5Q44C2D5UJY3TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRSGMYDKNBQGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6223054002>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXIEQCUTQNUU34I3SREHJEL5UJY3TAVCNFSNUABFKJSXA33TNF2G64TZHM4DAOBXG43DONRQHNEXG43VMU5TKNRWGQYDCMBSG4Z2C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables the Headlights button in the Refloat tab unless/until LEDs (or Lights, as they are sometimes called) are enabled, either by having been enabled in Refloat->LEDs->General->LEDs On or turned on with the Lights On button in Refloat.
UI elements that don't do anything create end user confusion and frustration. The potential for confusion is already high, given the relationships users must understand and navigate between these buttons and the Refloat Cfg settings and between LEDs (Lights) and Headlights in both places, not to mention needing to set the LED Mode in another menu. Let's give users a little incremental help here.