Skip to content

Disable Headlights button when LEDs/Lights not on - #106

Closed
OakCityDirtyRandy wants to merge 2 commits into
lukash:mainfrom
OakCityDirtyRandy:disable-button
Closed

OakCityDirtyRandy wants to merge 2 commits into
lukash:mainfrom
OakCityDirtyRandy:disable-button

Conversation

@OakCityDirtyRandy

Copy link
Copy Markdown
Contributor

This change disables the Headlights button in the Refloat tab unless/until LEDs (or Lights, as they are sometimes called) are enabled, either by having been enabled in Refloat->LEDs->General->LEDs On or turned on with the Lights On button in Refloat.

UI elements that don't do anything create end user confusion and frustration. The potential for confusion is already high, given the relationships users must understand and navigate between these buttons and the Refloat Cfg settings and between LEDs (Lights) and Headlights in both places, not to mention needing to set the LED Mode in another menu. Let's give users a little incremental help here.

@lukash

lukash commented Oct 16, 2026

Copy link
Copy Markdown
Owner

I'm fine with this. FWIW to give some unasked-for context, the buttons in the Control tab are kind of stop-gap, I wanted to do a generic "quick toggle" bar in the UI for which you'd be able to pick buttons, the two LED buttons would be part of that.

Could you just add a changelog line to the commit message? The convention is described in CONTRIBUTING.md, here you add something like:

Feature: Disable Headlights On/Off button if LEDs are Off

You'll get the attribution in the changelog too.

@lukash

lukash commented Oct 16, 2026

Copy link
Copy Markdown
Owner

You've added a merge commit to the PR branch, that shouldn't be there. I use a rebase workflow, if you want to get the latest main branch in, you need to rebase your branch on top of it and (force) push that to the PR branch.

@OakCityDirtyRandy

OakCityDirtyRandy commented Oct 16, 2026 via email

Copy link
Copy Markdown
Contributor Author

@OakCityDirtyRandy
OakCityDirtyRandy deleted the disable-button branch October 16, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants