Repository navigation
xag_npn: say which database the "size-optimum" brief refers to - #717
Merged
Merged
Conversation
The brief called the file's XAGs and AIGs size-optimum, but the default database is ABC's rewrite library, which is not size-optimum for 13 of the 135 NPN classes it covers (lsils#714). Wording proposed by the maintainer in that thread.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 191 191
Lines 29579 29579
=======================================
Hits 24876 24876
Misses 4703 4703 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the wording issue in #714.
The
\briefsaid the file's XAGs and AIGs are size-optimum. The default database is ABC's rewrite library (xag_npn_db_kind::xag_incomplete), which covers 135 of the 222 NPN classes of 4 variables and, for 13 of them, holds a circuit larger than the one in the complete XAG database of the same file. The complete databases from #455 are the ones the label fits: their designated output for every class matches the minimum size I get from exact synthesis, on all 221 non-constant classes, in both bases.The line is the one @myskyko proposed in the thread, unchanged. Docs only; no code and no data touched.