Repository navigation
Fix CodeQL Java build and add pull-request scans - #2193
Merged
Merged
Conversation
Deploying lowcoder-cloud with
|
| Latest commit: |
809f319
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://090f145d.lowcoder-cloud.pages.dev |
| Branch Preview URL: | https://codex-codeql-pr-checks.lowcoder-cloud.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
CodeQL Java fails before analysis because
clean compiledoes not produce the SDK test-helper JAR required by downstream modules. Build throughpackagewith-DskipTests, preserving test compilation while skipping test execution.Run Java and JavaScript CodeQL checks when pull requests are opened, updated, reopened, or marked ready for review. Preserve the main-branch and weekly scans and existing check names. Update CodeQL to v4, checkout to v6, and Java setup to v5, using explicit manual/none build modes and Java 17.
Types of changes
Validation
git diff --checkpassed.809f3190c: Java build and analysis succeeded, JavaScript analysis succeeded, and the code-scanning check reported no new alerts in this PR.Further comments
SonarCloud's separate
Quality Gate not computedresult is caused by the project's missing New Code definition. The dashboard explicitly reports that a new code definition is needed for long-lived branches; its API returns statusNONEwith no conditions or periods despite 30 recorded main-branch analyses. This requires a SonarCloud project setting and is independent of the CodeQL fix. No SonarCloud settings or gate thresholds are changed here.The SonarCloud PR workflow also needs separate attention: PR #2192 analysis checked out PR head
465c3f10but reported base revision8682fa4fand uploaded a branch analysis; SonarCloud has no recorded PR analysis for it. The currentpull_request_targetsetup supplies no explicit PR analysis parameters. Its successful job only confirms analysis submission, as it does not wait for the quality gate. Recommended follow-up: define the New Code baseline, configure correct PR identity and revision, and verify a computed gate on a fresh scan.