Add a scheduled target line to the BG graph - #755
Open
kristinkand wants to merge 12 commits into
Open
kristinkand wants to merge 12 commits into
kristinkand wants to merge 12 commits into
Conversation
Added targetGraphStruct to represent target data.
Added scheduled target marks to the chart view.
kristinkand
requested review from
bjorkert,
codebymini and
marionbarker
as code owners
September 23, 2026 10:14
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dashed line to the BG graph tracking the profile's routine, schedule-based BG
target (target_high) over time -- mirrors the existing scheduled basal line
(basalScheduleData / scheduledBasalMarks) exactly, substituting the target schedule
for the basal schedule.
This only ever reflects the routine schedule, the same way the basal line does --
an active Override, Temp Target, or Weekend Profile is still shown separately via the
existing colored bands, so this doesn't change that behavior. target_high is used
specifically because it's the same value the existing "Target" info row already reads
from (currentTargetHigh()), so the new line never disagrees with that number.
New setting: "Graph Target Line" in Advanced Settings, default on, matching the
existing "Graph Basal" toggle's pattern.