-
Notifications
You must be signed in to change notification settings - Fork 0
CI: run LocalStack via lstk instead of the localstack PyPI package #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
silv-io
merged 2 commits into
main
from
cosy-856-decouple-localstack-pypi-package-from-localstack-sdk-release
Aug 27, 2026
+30
−19
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,21 +33,23 @@ jobs: | |
| run: | | ||
| make install-dev | ||
|
|
||
| - name: Install LocalStack | ||
| - name: Install lstk | ||
| run: | | ||
| pip install --pre --upgrade localstack | ||
| npm install -g @localstack/lstk | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hopefully at some point lstk releases a github action? 👀
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. setup-localstack should probably handle the install in the future, yeah |
||
|
|
||
| - name: Pull image | ||
| run: | | ||
| docker pull localstack/localstack-pro | ||
|
|
||
| # lstk defaults to the aws emulator with image localstack/localstack-pro:latest, | ||
| # so no config file is needed here. | ||
| - name: Start Localstack | ||
| env: | ||
| LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }} | ||
| LOCALSTACK_AUTH_TOKEN: ${{ secrets.LOCALSTACK_AUTH_TOKEN }} | ||
| LOCALSTACK_DEBUG: "1" | ||
| LOCALSTACK_DISABLE_EVENTS: "1" | ||
| run: | | ||
| source .venv/bin/activate | ||
| DEBUG=1 DISABLE_EVENTS="1" IMAGE_NAME="localstack/localstack-pro:latest" localstack start -d | ||
| localstack wait -t 120 || (python -m localstack.cli.main logs && false) | ||
| lstk start --timeout 2m | ||
|
|
||
| - name: Run Python Tests | ||
| env: | ||
|
|
@@ -58,6 +60,5 @@ jobs: | |
| - name: Stop Localstack | ||
| if: always() | ||
| run: | | ||
| source .venv/bin/activate | ||
| localstack logs | ||
| localstack stop | ||
| lstk logs | ||
| lstk stop | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity is it possible at all to change the chosen image without using the config ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our decision back then was to consciously have the main way of doing this be the config file.
Could be that we added option overrides since then, but IMO both locally and in CI it's better to just have a clear file that defines your setup vs. attaching an increasing list of CLI parameters to your call.