Skip to content

Run the file storage sample's scripts on macOS's bash 3.2 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paolosalvatori merged 1 commit into from
Nov 4, 2026
Merged

Run the file storage sample's scripts on macOS's bash 3.2 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion samples/web-app-file-storage/dotnet/scripts/00-variables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
# Variables

# Lowercase and uppercase conversions that also run on bash 3.2, the /bin/bash of macOS: the
# ${value,,} and ${value^^} expansions need bash 4 and fail there with "bad substitution".
lowercase() {
printf '%s' "$1" | tr '[:upper:]' '[:lower:]'
}

uppercase() {
printf '%s' "$1" | tr '[:lower:]' '[:upper:]'
}

# Azure Resources
PREFIX='local'
SUFFIX='test'
LOCATION='italynorth'
RESOURCE_GROUP_NAME="${PREFIX}-rg"
ACR_NAME="${PREFIX,,}acr${SUFFIX,,}"
ACR_NAME="$(lowercase "$PREFIX")acr$(lowercase "$SUFFIX")"
ACR_SKU='Standard'
AKS_CLUSTER_NAME="${PREFIX}-aks-${SUFFIX}"
SUBSCRIPTION_NAME=$(az account show --query name --output tsv)
Expand Down
6 changes: 3 additions & 3 deletions samples/web-app-file-storage/dotnet/scripts/01-deploy-resources.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ if [[ -z "$PROVISIONING_MODE" ]]; then
done
fi

PROVISIONING_MODE="${PROVISIONING_MODE,,}"
PROVISIONING_MODE="$(lowercase "$PROVISIONING_MODE")"

if [[ "$PROVISIONING_MODE" != 'static' && "$PROVISIONING_MODE" != 'dynamic' ]]; then
echo "Invalid provisioning mode [$PROVISIONING_MODE]: expected [static] or [dynamic]"
Expand Down Expand Up @@ -80,7 +80,7 @@ if [[ -z "$FILE_SHARE_PROTOCOL" ]]; then
done
fi

FILE_SHARE_PROTOCOL="${FILE_SHARE_PROTOCOL,,}"
FILE_SHARE_PROTOCOL="$(lowercase "$FILE_SHARE_PROTOCOL")"

if [[ "$FILE_SHARE_PROTOCOL" != 'smb' && "$FILE_SHARE_PROTOCOL" != 'nfs' ]]; then
echo "Invalid file share protocol [$FILE_SHARE_PROTOCOL]: expected [smb] or [nfs]"
Expand All @@ -104,7 +104,7 @@ else
exit 1
fi

echo "Deploying the resources for [$PROVISIONING_MODE] provisioning over [${FILE_SHARE_PROTOCOL^^}]..."
echo "Deploying the resources for [$PROVISIONING_MODE] provisioning over [$(uppercase "$FILE_SHARE_PROTOCOL")]..."

# Create a resource group
echo "Checking if resource group [$RESOURCE_GROUP_NAME] exists in the subscription [$SUBSCRIPTION_NAME]..."
Expand Down
4 changes: 2 additions & 2 deletions samples/web-app-file-storage/dotnet/scripts/04-push-docker-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ fi
FULL_IMAGE="${ACR_LOGIN_SERVER}/${IMAGE_NAME}:${IMAGE_TAG}"

# Tag the local image with the loginServer of ACR
docker tag ${IMAGE_NAME,,}:$IMAGE_TAG $ACR_LOGIN_SERVER/${IMAGE_NAME,,}:$IMAGE_TAG
docker tag $(lowercase "$IMAGE_NAME"):$IMAGE_TAG $ACR_LOGIN_SERVER/$(lowercase "$IMAGE_NAME"):$IMAGE_TAG

if [ $? -eq 0 ]; then
echo "Docker image [$IMAGE_NAME] tagged as [$FULL_IMAGE] successfully."
Expand All @@ -30,7 +30,7 @@ else
fi

# Push the container image to ACR
docker push $ACR_LOGIN_SERVER/${IMAGE_NAME,,}:$IMAGE_TAG
docker push $ACR_LOGIN_SERVER/$(lowercase "$IMAGE_NAME"):$IMAGE_TAG

if [ $? -eq 0 ]; then
echo "Docker image [$FULL_IMAGE] pushed to ACR successfully."
Expand Down
2 changes: 1 addition & 1 deletion samples/web-app-file-storage/dotnet/scripts/05-deploy-app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if [[ "$FILE_SHARE_PROTOCOL" != 'smb' && "$FILE_SHARE_PROTOCOL" != 'nfs' ]]; the
exit 1
fi

echo "Deploying the app with [$PROVISIONING_MODE] provisioning over [${FILE_SHARE_PROTOCOL^^}]..."
echo "Deploying the app with [$PROVISIONING_MODE] provisioning over [$(uppercase "$FILE_SHARE_PROTOCOL")]..."

# Pick the storage account that holds the file share for the selected protocol
if [[ "$FILE_SHARE_PROTOCOL" == 'nfs' ]]; then
Expand Down
12 changes: 11 additions & 1 deletion samples/web-app-file-storage/python/scripts/00-variables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
# Variables

# Lowercase and uppercase conversions that also run on bash 3.2, the /bin/bash of macOS: the
# ${value,,} and ${value^^} expansions need bash 4 and fail there with "bad substitution".
lowercase() {
printf '%s' "$1" | tr '[:upper:]' '[:lower:]'
}

uppercase() {
printf '%s' "$1" | tr '[:lower:]' '[:upper:]'
}

# Azure Resources
PREFIX='local'
SUFFIX='test'
LOCATION='italynorth'
RESOURCE_GROUP_NAME="${PREFIX}-rg"
ACR_NAME="${PREFIX,,}acr${SUFFIX,,}"
ACR_NAME="$(lowercase "$PREFIX")acr$(lowercase "$SUFFIX")"
ACR_SKU='Standard'
AKS_CLUSTER_NAME="${PREFIX}-aks-${SUFFIX}"
SUBSCRIPTION_NAME=$(az account show --query name --output tsv)
Expand Down
6 changes: 3 additions & 3 deletions samples/web-app-file-storage/python/scripts/01-deploy-resources.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ if [[ -z "$PROVISIONING_MODE" ]]; then
done
fi

PROVISIONING_MODE="${PROVISIONING_MODE,,}"
PROVISIONING_MODE="$(lowercase "$PROVISIONING_MODE")"

if [[ "$PROVISIONING_MODE" != 'static' && "$PROVISIONING_MODE" != 'dynamic' ]]; then
echo "Invalid provisioning mode [$PROVISIONING_MODE]: expected [static] or [dynamic]"
Expand Down Expand Up @@ -80,7 +80,7 @@ if [[ -z "$FILE_SHARE_PROTOCOL" ]]; then
done
fi

FILE_SHARE_PROTOCOL="${FILE_SHARE_PROTOCOL,,}"
FILE_SHARE_PROTOCOL="$(lowercase "$FILE_SHARE_PROTOCOL")"

if [[ "$FILE_SHARE_PROTOCOL" != 'smb' && "$FILE_SHARE_PROTOCOL" != 'nfs' ]]; then
echo "Invalid file share protocol [$FILE_SHARE_PROTOCOL]: expected [smb] or [nfs]"
Expand All @@ -104,7 +104,7 @@ else
exit 1
fi

echo "Deploying the resources for [$PROVISIONING_MODE] provisioning over [${FILE_SHARE_PROTOCOL^^}]..."
echo "Deploying the resources for [$PROVISIONING_MODE] provisioning over [$(uppercase "$FILE_SHARE_PROTOCOL")]..."

# Create a resource group
echo "Checking if resource group [$RESOURCE_GROUP_NAME] exists in the subscription [$SUBSCRIPTION_NAME]..."
Expand Down
4 changes: 2 additions & 2 deletions samples/web-app-file-storage/python/scripts/04-push-docker-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ fi
FULL_IMAGE="${ACR_LOGIN_SERVER}/${IMAGE_NAME}:${IMAGE_TAG}"

# Tag the local image with the loginServer of ACR
docker tag ${IMAGE_NAME,,}:$IMAGE_TAG $ACR_LOGIN_SERVER/${IMAGE_NAME,,}:$IMAGE_TAG
docker tag $(lowercase "$IMAGE_NAME"):$IMAGE_TAG $ACR_LOGIN_SERVER/$(lowercase "$IMAGE_NAME"):$IMAGE_TAG

if [ $? -eq 0 ]; then
echo "Docker image [$IMAGE_NAME] tagged as [$FULL_IMAGE] successfully."
Expand All @@ -30,7 +30,7 @@ else
fi

# Push the container image to ACR
docker push $ACR_LOGIN_SERVER/${IMAGE_NAME,,}:$IMAGE_TAG
docker push $ACR_LOGIN_SERVER/$(lowercase "$IMAGE_NAME"):$IMAGE_TAG

if [ $? -eq 0 ]; then
echo "Docker image [$FULL_IMAGE] pushed to ACR successfully."
Expand Down
2 changes: 1 addition & 1 deletion samples/web-app-file-storage/python/scripts/05-deploy-app.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if [[ "$FILE_SHARE_PROTOCOL" != 'smb' && "$FILE_SHARE_PROTOCOL" != 'nfs' ]]; the
exit 1
fi

echo "Deploying the app with [$PROVISIONING_MODE] provisioning over [${FILE_SHARE_PROTOCOL^^}]..."
echo "Deploying the app with [$PROVISIONING_MODE] provisioning over [$(uppercase "$FILE_SHARE_PROTOCOL")]..."

# Pick the storage account that holds the file share for the selected protocol
if [[ "$FILE_SHARE_PROTOCOL" == 'nfs' ]]; then
Expand Down
Loading