Preserve dataset files when JSONL generation fails - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A serialization error or interrupted input iterator previously truncated an existing dataset and left partial output. Write to a temporary file in the destination directory and atomically replace the destination only after successful serialization and close. Clean up temporary files on failure.
Keep iterable input, Unicode output and empty-file behavior. Document atomic replacement's scope, including new-file permissions and the absence of power-loss or concurrent-writer guarantees. Add Linux/Windows CI.
Validation: all 72 tests pass, including 7 new regressions for replacement, Unicode, empty input, serialization/iteration failure and failed replacement.