Fix device transfer without losing graph attributes - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graph attributes previously raised
NameErrorbecause the helper referenced an undefinedDEVICE, and the failed transfer removed the source attribute. Use the caller's device and retain the current attribute when conversion fails.Extract the dependency-free operation into
GraphLib/device.py, preserving the existingGraphLib.dglutilentry point, keyword arguments, graph identity and in-place behavior. Earlier successful transfers are not rolled back. Add component CI and document the contract.Validation: 5 regression tests pass for node/edge transfers, requested devices, failed transfers and empty graphs; changed modules compile. Tests use protocol doubles and do not claim DGL/GPU or model-training validation.
Closes #1.